Skins: fix time display to allow AM/PM - #13430

Looks good. However I like the 24:00 format more in Shade, I can however not imagine if it is readable if you are not used to it.

However I like the 24:00 format more in Shade

This is not enforcing AM/PM. By default, WTime uses the system's time locale. So I assume @RafaelFrance has that set in his system. @RafaelFrance can you confirm?
I use en_GB for lang, all other settings (time, measures) are de_DE, and I had to enforce AM/PM in order to see it in Mixxx.
I have reset my system clock to hh:mm and that's how it looks like in Mixxx now.

Yes, when using Mixxx, I use OS system format (24:00 hour format, French language). No problem.

But when testing Mixxx, I change to English language in Mixxx preferences, in order to report issues with correct wording. I think that here I set English (United States) format.

Thanks for verifying!
Do you have time to test the CI build from https://github.com/mixxxdj/mixxx/actions/runs/9751678277?pr=13430#artifacts?

Interesting could be the opinion of English speaking users. Do they prefer the military time for a compact display or the AM/PM format which is more common.

@ywwg ?

Tested. Git Version : 2.4.1-36-ga9b6791259 (HEAD).

AM/PM is absent. Only "10:02" in place of "10:02 PM".

cross-posting from #13421:

I can verifiy AM/PM is used when I pick the en_US locale in Mixxx. You not seeing AM/PM must be a locale issue. What locale do you use for Mixxx when you expect AM/PM?

My laptop system is : French.

When testing I used English (United States) local in Preference/Interface of Mixxx.
It is the same setting that when I found the issue on #13421

Note : when I use Mixxx I do not have any problem because Mixxx is set on "System" and hours are in 24h.

Well, that means something else (not Mixxx) is not as before, because in Tango I only changed the size not the time config (other skins now allow AP/PM, too)
https://github.com/mixxxdj/mixxx/pull/13430/files#diff-014090a33661d1e7219e18239a7a9482c2f6d4a0436ad5c43cd7ebedfbf7eb7f

thanks for this! I should have looked first

So, let's merge?

is it worth fixing this for 2.4? it's not a huge issue and backporting is a pain, so how about we target 2.5? Not a strong opinion

I don't understand, this is already targeting 2.4 and, as far as I'm aware, the toolbars and mixer in Shade didn't change recently, so merging 2.4 into 2.5 will be easy.